Use pixels for @media queries
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These `@media` queries are concerned with displaying a side panel that is explicitly 300px wide. Therefore, they should be expressed in terms of pixels instead of variable-width units. Also note that `em` in a `@media` query is based on the default font size of the browser configured by the user, _not_ the font size of `<body>`, which seems to have been the intention with these (40 * 15px == 600px => equal space for panel and content).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
@mediaqueries are concerned with displaying a side panel that is explicitly 300px wide. Therefore, they should be expressed in terms of pixels instead of variable-width units. Also note thatemin a@mediaquery is based on the default font size of the browser configured by the user, not the font size of<body>, which seems to have been the intention with these (40 * 15px == 600px => equal space for panel and content).